Bug Report T677174
Visible to All Users

Static Code Analysis - The "Possible System.NullReferenceException" diagnostic should take Return in If-ElseIf with For-Each-Statement into account

created 6 years ago

Please see following example:

Visual Basic
Public Class Class1 Public Function Foo1(items As Object()) As Object If items Is Nothing Then Return "Something" ElseIf items.Count = 0 Then Return "Something else" End If 'CRR0027 (false positive) For Each item As Object In items 'Do something Next 'No CRR0027 Return items.Count End Function Public Function Bar1(items As Object()) As Object If items Is Nothing Then Return "Something" End If If items.Count = 0 Then Return "Something else" End If 'No CRR0027 For Each item As Object In items 'Do something Next 'No CRR0027 Return items.Count End Function Public Function Foo2(value As Object) As String If value Is Nothing Then Return "Something" ElseIf TypeOf value Is Integer Then Return "Something else" End If 'CRR0027 (false positive) Return $"{value.GetType.Name}" End Function Public Function Bar2(value As Object) As String If value Is Nothing Then Return "Something" End If If TypeOf value Is Integer Then Return "Something else" End If 'No CRR0027 Return $"{value.GetType.Name}" End Function End Class
Comments (1)
DevExpress Support Team 6 years ago

    Hi Robert,

    Thank you for providing the code sample. I have reproduced this issue with "Possible System.NullReferenceException" false positives. We are working on it and will inform you of our progress.

    Answers approved by DevExpress Support

    created 6 years ago

    We have fixed the issue described in this ticket and will include the fix in our next maintenance update. To apply this solution before the official update, request a hotfix by clicking the corresponding link for product versions you require.

    Note: Hotfixes may be unavailable for beta versions and updates that are about to be released.

      Disclaimer: The information provided on DevExpress.com and affiliated web properties (including the DevExpress Support Center) is provided "as is" without warranty of any kind. Developer Express Inc disclaims all warranties, either express or implied, including the warranties of merchantability and fitness for a particular purpose. Please refer to the DevExpress.com Website Terms of Use for more information in this regard.

      Confidential Information: Developer Express Inc does not wish to receive, will not act to procure, nor will it solicit, confidential or proprietary materials and information from you through the DevExpress Support Center or its web properties. Any and all materials or information divulged during chats, email communications, online discussions, Support Center tickets, or made available to Developer Express Inc in any manner will be deemed NOT to be confidential by Developer Express Inc. Please refer to the DevExpress.com Website Terms of Use for more information in this regard.