Bug Report T550728
Visible to All Users

Refactorings - "Convert to Property with Change Notification" incorrectly produces new code if the SetProperty method was present in the initial one

created 7 years ago

When I run the Convert to Property with Change Notification template on this code:

C#
public int VendorId { get; set; }

in a class that has this SetProperty method

C#
protected bool SetProperty<T>(ref T storage, T value, [CallerMemberName] string propertyName = null) { if (Equals(storage, value)) return false; storage = value; this.RaisePropertyChanged(propertyName); return true; }

I need something like this

C#
int vendorId public int VendorId { get { return vendorId; } set { SetProperty(ref vendorId, value); } }

I get this instead

C#
int vendorId; public int VendorId { get { return vendorId; } set { if (vendorId == value) { return; } vendorId = value; SetProperty(ref default(T), default(T)); } }

Is there a way for the template expansion to create the code I need?

Comments (1)
DevExpress Support Team 7 years ago

    Darin,

    I have reproduced this issue with the following code:

    C#
    using System.ComponentModel; using System.Runtime.CompilerServices; namespace TestNamespace { public class TestClass : INotifyPropertyChanged { public event PropertyChangedEventHandler PropertyChanged; protected void RaisePropertyChanged(string propertyName) { PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName)); } protected bool SetProperty<T>(ref T storage, T value, [CallerMemberName] string propertyName = null) { if (Equals(storage, value)) return false; storage = value; this.RaisePropertyChanged(propertyName); return true; } public int VendorId { get; set; } } }

    After applying "Convert to Property with Change Notification", I get code that doesn't compile. Please give us some time to fix this problem. I will inform you of our results.

    Answers approved by DevExpress Support

    created 7 years ago (modified 7 years ago)

    We have fixed the issue described in this ticket and will include the fix in our next maintenance update. To apply this solution before the official update, request a hotfix by clicking the corresponding link for product versions you require.

    Note: Hotfixes may be unavailable for beta versions and updates that are about to be released.

      Disclaimer: The information provided on DevExpress.com and affiliated web properties (including the DevExpress Support Center) is provided "as is" without warranty of any kind. Developer Express Inc disclaims all warranties, either express or implied, including the warranties of merchantability and fitness for a particular purpose. Please refer to the DevExpress.com Website Terms of Use for more information in this regard.

      Confidential Information: Developer Express Inc does not wish to receive, will not act to procure, nor will it solicit, confidential or proprietary materials and information from you through the DevExpress Support Center or its web properties. Any and all materials or information divulged during chats, email communications, online discussions, Support Center tickets, or made available to Developer Express Inc in any manner will be deemed NOT to be confidential by Developer Express Inc. Please refer to the DevExpress.com Website Terms of Use for more information in this regard.