Bug Report T416551
Visible to All Users

Reverse Boolean refactoring does not update constructor parameters in attributes

created 9 years ago

This problem actually applies to the legacy CodeRush as well it seems.

Consider the following classes:

C#
class MyAttribute : Attribute { public MyAttribute(bool isSet) { IsSet = isSet; } public bool IsSet { get; } } [My(true)] class Program { static void Main(string[] args) { bool value = true; MyAttribute attr = new MyAttribute(false); attr = new MyAttribute(value); } }

If you place the cursor on the isSet parameter of the MyAttribute constructor, and invoke the "Reverse Boolean" refactoring, the usages are updated everywhere, except when the class is used as an attribute.  So [My(true)] is left unchanged, when it should have been changed to [My(false)] .

Show previous comments (1)

    It seems this problem applies to the "Boolean to enum" conversion as well.

    DevExpress Support Team 9 years ago

      Peter,

      Thank you for the additional information. It seems that it is a similar issue but in different refactoring, and it will be better to discuss it in a separate thread.
      So, I have created a new ticket on your behalf: Boolean to Enum refactoring does not update ctor parameters in attributes. Please refer to it for further correspondence.

        Great, thank you very much.

        Answers approved by DevExpress Support

        created 9 years ago

        We have fixed the issue described in this ticket and will include the fix in our next maintenance update. To apply this solution before the official update, request a hotfix by clicking the corresponding link for product versions you require.

        Note: Hotfixes may be unavailable for beta versions and updates that are about to be released.

          Disclaimer: The information provided on DevExpress.com and affiliated web properties (including the DevExpress Support Center) is provided "as is" without warranty of any kind. Developer Express Inc disclaims all warranties, either express or implied, including the warranties of merchantability and fitness for a particular purpose. Please refer to the DevExpress.com Website Terms of Use for more information in this regard.

          Confidential Information: Developer Express Inc does not wish to receive, will not act to procure, nor will it solicit, confidential or proprietary materials and information from you through the DevExpress Support Center or its web properties. Any and all materials or information divulged during chats, email communications, online discussions, Support Center tickets, or made available to Developer Express Inc in any manner will be deemed NOT to be confidential by Developer Express Inc. Please refer to the DevExpress.com Website Terms of Use for more information in this regard.