Bug Report T393698
Visible to All Users

Code Cleanup - "Use nameof" - The "nameof" operator is incorrectly added to every string constant that matches a variable name

created 9 years ago

With Code Cleanup options set such that the "Use 'naemof'" option is checked, given a method like this:

C#
public void Test() { var key = new ApiKey { Id = 5 }; if(String.Compare(key.Id.ToString(), "key") == 0) { throw new Exception(); } }

When I apply Code Cleanup, the "nameof" operator gets incorrectly added to literally every string constant that matches a variable name, which results in things like this:

C#
public void Test() { var key = new ApiKey { Id = 5 }; if (string.Compare(key.Id.ToString(), nameof(key)) == 0) { throw new Exception(); } }

I would expect "nameof" to really only be applied in expressions that throw an exception or otherwise would normally be expected to be using the names of variables.

Comments (1)
DevExpress Support Team 9 years ago

    Hi Travis,
    Thank you for pointing out this issue. I passed this ticket to our developers. Once they find an appropriate solution, you will be immediately notified via email.

    Answers approved by DevExpress Support

    created 9 years ago

    We have fixed the issue described in this ticket and will include the fix in our next maintenance update. To apply this solution before the official update, request a hotfix by clicking the corresponding link for product versions you require.

    Note: Hotfixes may be unavailable for beta versions and updates that are about to be released.

      Disclaimer: The information provided on DevExpress.com and affiliated web properties (including the DevExpress Support Center) is provided "as is" without warranty of any kind. Developer Express Inc disclaims all warranties, either express or implied, including the warranties of merchantability and fitness for a particular purpose. Please refer to the DevExpress.com Website Terms of Use for more information in this regard.

      Confidential Information: Developer Express Inc does not wish to receive, will not act to procure, nor will it solicit, confidential or proprietary materials and information from you through the DevExpress Support Center or its web properties. Any and all materials or information divulged during chats, email communications, online discussions, Support Center tickets, or made available to Developer Express Inc in any manner will be deemed NOT to be confidential by Developer Express Inc. Please refer to the DevExpress.com Website Terms of Use for more information in this regard.