Bug Report T1161896
Visible to All Users

Convert to Ternary Expression refactoring introduces changes in code behavior

created 2 years ago (modified 2 years ago)

There is a subtle bug in convert if statement to ternary expression.
Consider the code below.
AfterRefactor is method after if statement has been refactored to ternary expression. It looks fine, but it has a subtle different behavior - the return type is long instead of an int.
Value 1 should be cast to object to make it correct, like
return flag ? (object)1 : (long)0;

C#
Console.WriteLine(Tubo.Properly(true).GetType().Name); Console.WriteLine(Tubo.AfterRefactor(true).GetType().Name); internal class Tubo { public static object Properly(bool flag) { if (flag) { return (int)1; } else { return (long)0; } } public static object AfterRefactor(bool flag) { return flag ? (int)1 : (long)0; } }
Comments (1)
PW PW
Przemyslaw Wlodarczak (DevExpress) 2 years ago

    Miha,

    I reproduced this behavior. We will research it and update this thread as soon as we have news.

    Answers approved by DevExpress Support

    created 2 years ago

    We have addressed the issue described in this ticket and will include a fix in our next maintenance update. Should you need to apply our fix prior to official release, you can request a hotfix here.

    Important Notes:

    • Hotfixes may be unavailable for Early Access/Beta builds or updates set for release within a week.
    • .NET only: in the NuGet Package Manager, use your personal NuGet feed and check the "Include prerelease" option to view the hotfix package in the "Updates" tab.

      Disclaimer: The information provided on DevExpress.com and affiliated web properties (including the DevExpress Support Center) is provided "as is" without warranty of any kind. Developer Express Inc disclaims all warranties, either express or implied, including the warranties of merchantability and fitness for a particular purpose. Please refer to the DevExpress.com Website Terms of Use for more information in this regard.

      Confidential Information: Developer Express Inc does not wish to receive, will not act to procure, nor will it solicit, confidential or proprietary materials and information from you through the DevExpress Support Center or its web properties. Any and all materials or information divulged during chats, email communications, online discussions, Support Center tickets, or made available to Developer Express Inc in any manner will be deemed NOT to be confidential by Developer Express Inc. Please refer to the DevExpress.com Website Terms of Use for more information in this regard.