BuyLog In
Bug Report Q502704
Visible to All Users

Parameters of certain Windows message sending methods are not 64-bit safe

created 12 years ago

The OnChange event for TdxBarCombo controls doesn't always fire on 64-bit Windows. Making the following change to dxBar.pas fixes the issue:
// line 30849

Delphi
function TdxBarWinControl.GetText: string;  
var  
  S: PChar;  
  Len: Integer;  
begin  
  if Handle <> 0 then  
  begin  
    S := StrAlloc(256);  
    Len := SendMessage(Handle, WM_GETTEXT, 255, LPARAM(S)); // cast changed from LongInt to LPARAM  
    if Len = 0 then  
      Result := ''  
    else  
      Result := S;  
    StrDispose(S);  
  end;  
end;
Comments (3)
GM GM
Gareth Marshall 12 years ago

    A similar problem seems to exist in dxBarExtDBItems.pas:
    Line 603 should probably be (in TdxBarLookupCombo.KeyPress):
          SendMessage(GetEditHandle, EM_GETSEL, WPARAM(@AStartPos), LPARAM(@AEndPos));

    GM GM
    Gareth Marshall 12 years ago

      Also cxTextEdit.pas line 5226 (in TcxCustomTextEdit.WndProc):
                SendMessageW(InnerControl.Handle, EM_REPLACESEL, 1, LPARAM(PWideChar(Replacement)));
      And dxSpellCheckerAutoCorrect line 403 (in TdxSpellCheckerAutoCorrectManager.ApplyChanges):
               PostMessageW(Adapter.EditorHandle, DXM_SPELL_AUTOCORRECT, 0, LPARAM(@dxSpellCheckerAutoCorrectWord));
      Doing a search for PostMessage() and SendMessage() found similar issues in some of the demo projects, but I won't list those here.

      DevExpress Support Team 12 years ago

        Thank you for your valuable research. I have forwarded this ticket to our developers for further investigation.

        Sign in to comment on this post

        Answers approved by DevExpress Support

        created 12 years ago (modified 12 years ago)

        We have fixed the issue described in this ticket and will include the fix in our next maintenance update. To apply this solution before the official update, request a hotfix by clicking the corresponding link for product versions you require.

        Note: Hotfixes may be unavailable for beta versions and updates that are about to be released.

          Comments (3)
          DevExpress Support Team 12 years ago

            Hello Gareth,
            We have fixed the issue. Would you mind us publishing the content of this ticket? It can help other programmers who faced a similar problem.

            GM GM
            Gareth Marshall 12 years ago

              I'm happy for you to do so - I generally just make tickets that include your source code private.

              DevExpress Support Team 12 years ago

                I have published this ticket. Thanks again for your valuable research.

                Sign in to comment on this post

                Disclaimer: The information provided on DevExpress.com and affiliated web properties (including the DevExpress Support Center) is provided "as is" without warranty of any kind. Developer Express Inc disclaims all warranties, either express or implied, including the warranties of merchantability and fitness for a particular purpose. Please refer to the DevExpress.com Website Terms of Use for more information in this regard.

                Confidential Information: Developer Express Inc does not wish to receive, will not act to procure, nor will it solicit, confidential or proprietary materials and information from you through the DevExpress Support Center or its web properties. Any and all materials or information divulged during chats, email communications, online discussions, Support Center tickets, or made available to Developer Express Inc in any manner will be deemed NOT to be confidential by Developer Express Inc. Please refer to the DevExpress.com Website Terms of Use for more information in this regard.