BuyLog In
Bug Report B134174
Visible to All Users

Refactoring - "Expand ternary expression" refactoring makes the code uncompilable

created 16 years ago

When refactoring unmanaged C++ code from ternary to conditional, method1()->method2() becomes method2(). Refactored code may fail to compile.
Steps to Reproduce:
void CHP8753E::SplitDisplay(bool v_TorF) const
{
    pInstrumentInterface()->Send((v_TorF) ? "SPLD ON;" : "SPLD OFF;");
}
Actual Results:
void CHP8753E::SplitDisplay(bool v_TorF) const
{
    if ((v_TorF))
        Send("SPLD ON;");
    else
        Send("SPLD OFF;");
}
Expected Results:
void CHP8753E::SplitDisplay(bool v_TorF) const
{
    if ((v_TorF))
        pInstrumentInterface()->Send("SPLD ON;");
    else
        pInstrumentInterface()->Send("SPLD OFF;");
}

Sign in to comment on this post

Disclaimer: The information provided on DevExpress.com and affiliated web properties (including the DevExpress Support Center) is provided "as is" without warranty of any kind. Developer Express Inc disclaims all warranties, either express or implied, including the warranties of merchantability and fitness for a particular purpose. Please refer to the DevExpress.com Website Terms of Use for more information in this regard.

Confidential Information: Developer Express Inc does not wish to receive, will not act to procure, nor will it solicit, confidential or proprietary materials and information from you through the DevExpress Support Center or its web properties. Any and all materials or information divulged during chats, email communications, online discussions, Support Center tickets, or made available to Developer Express Inc in any manner will be deemed NOT to be confidential by Developer Express Inc. Please refer to the DevExpress.com Website Terms of Use for more information in this regard.